mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258221771
########## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java ########## @@ -101,6 +118,21 @@ private final JobContext jobContext; private final ContainerContext containerContext; + /* Sideinput related parameters */ + private final Map<String, List<SystemStream>> sideInputSystemStreams; // Map of side input system-streams indexed by store name + private final Map<TaskName, Map<String, Set<SystemStreamPartition>>> sideInputSSPs; Review comment: Cosmetics: I noticed you wrap side inputs related parameters within a task context or some map. Can we rename them to make it clear. e.g. sideInputSSPs, makes me think its a set but its a map from task to a map of store to set of ssps. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
