mynameborat commented on a change in pull request #912: SEP-19 : Refactoring
sideInputs from SamzaContainer to ContainerStorageManager
URL: https://github.com/apache/samza/pull/912#discussion_r259958242
##########
File path:
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
##########
@@ -836,7 +771,10 @@ class SamzaContainer(
containerListener.afterStart()
}
metrics.containerStartupTime.update(System.nanoTime() - startTime)
- runLoop.run
+ if (taskInstances.size > 0)
Review comment:
can we have this persisted as a boolean or maybe enum representing the
container is standby? Especially, if we were to account for mix match, standby
and active. It is much easier to reason about why we start and stop components
in some places as opposed to infer the container is standby from
`taskInstances.size = 0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
