mynameborat commented on a change in pull request #912: SEP-19 : Refactoring
sideInputs from SamzaContainer to ContainerStorageManager
URL: https://github.com/apache/samza/pull/912#discussion_r259952050
##########
File path:
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
##########
@@ -656,13 +593,11 @@ object SamzaContainer extends Logging {
storageManager = storageManager,
tableManager = tableManager,
reporters = reporters,
- systemStreamPartitions = taskSSPs,
+ systemStreamPartitions = taskSSPs -- taskSideInputSSPs,
Review comment:
Are we piggy backing on ssps within task model to pass the side inputs too?
Should we have something similar to changelog partition in task model that
represents the side inputs separately so that we don't have to handle for side
inputs in places where taskSSPs is used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
