cameronlee314 commented on a change in pull request #79: Update doc and javadoc from config factory to config loader URL: https://github.com/apache/samza-hello-samza/pull/79#discussion_r399574730
########## File path: README.md ########## @@ -61,13 +61,19 @@ Package [samza.examples.cookbook](https://github.com/apache/samza-hello-samza/tr Package [samza.examples.wikipedia.application](https://github.com/apache/samza-hello-samza/tree/master/src/main/java/samza/examples/wikipedia/application) contains a small Samza application which consumes the real-time feeds from Wikipedia, extracts the metadata of the events, and calculates statistics of all edits in a 10-second window. You can start the app on the grid using the run-app.sh script: ``` -./deploy/samza/bin/run-app.sh --config-factory=org.apache.samza.config.factories.PropertiesConfigFactory --config-path=file://$PWD/deploy/samza/config/wikipedia-application.properties +./deploy/samza/bin/run-app.sh \ + --config app.class=samza.examples.wikipedia.application.WikipediaApplication \ + --config yarn.package.path=file:///Users/kwu/workspace/hello-samza/target/hello-samza-1.5.0-SNAPSHOT-dist.tar.gz \ + --config job.name=wikipedia-application \ + --config job.factory.class=org.apache.samza.job.yarn.YarnJobFactory \ Review comment: These all seem to be copied from the properties file. It seems like it would be non-trivial to keep the properties file and this list of configs consistent, since they are in different places. https://github.com/apache/samza/pull/1256 indicates that you only need the config loader and properties path, but here you are adding several other configs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
