cameronlee314 commented on a change in pull request #79: Update doc and javadoc
from config factory to config loader
URL: https://github.com/apache/samza-hello-samza/pull/79#discussion_r404301906
##########
File path: src/main/config/azure-blob-application.properties
##########
@@ -30,10 +30,14 @@
yarn.package.path=file://${basedir}/target/${project.artifactId}-${pom.version}-
# StreamApplication class
app.class=samza.examples.azure.AzureBlobApplication
-#Azure blob essential configs
+# Azure blob essential configs
systems.azure-blob-container.samza.factory=org.apache.samza.system.azureblob.AzureBlobSystemFactory
sensitive.systems.azure-blob-container.azureblob.account.name=your-azure-storage-account-name
sensitive.systems.azure-blob-container.azureblob.account.key=your-azure-storage-account-key
+# Config Loader
+job.config.loader.factory=org.apache.samza.config.loaders.PropertiesConfigLoaderFactory
+job.config.loader.properties.path=./__package/config/azure-blob-application.properties
Review comment:
Do you think it might be confusing to users what `__package` refers to? That
is kind of a YARN implementation detail. Maybe documentation can help clarify,
but if you can find a programatic way to hide that implementation detail, that
would be nice too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
