cameronlee314 commented on a change in pull request #79: Update doc and javadoc from config factory to config loader URL: https://github.com/apache/samza-hello-samza/pull/79#discussion_r400365471
########## File path: README.md ########## @@ -61,13 +61,19 @@ Package [samza.examples.cookbook](https://github.com/apache/samza-hello-samza/tr Package [samza.examples.wikipedia.application](https://github.com/apache/samza-hello-samza/tree/master/src/main/java/samza/examples/wikipedia/application) contains a small Samza application which consumes the real-time feeds from Wikipedia, extracts the metadata of the events, and calculates statistics of all edits in a 10-second window. You can start the app on the grid using the run-app.sh script: ``` -./deploy/samza/bin/run-app.sh --config-factory=org.apache.samza.config.factories.PropertiesConfigFactory --config-path=file://$PWD/deploy/samza/config/wikipedia-application.properties +./deploy/samza/bin/run-app.sh \ + --config app.class=samza.examples.wikipedia.application.WikipediaApplication \ + --config yarn.package.path=file:///Users/kwu/workspace/hello-samza/target/hello-samza-1.5.0-SNAPSHOT-dist.tar.gz \ + --config job.name=wikipedia-application \ + --config job.factory.class=org.apache.samza.job.yarn.YarnJobFactory \ Review comment: Do you have a clean way to describe how to specify submission configs in general? Based on your comments, it seems like standalone (`LocalApplicationRunner`) specifies a different set of submission configs than YARN (`RemoteApplicationRunner`), even though some of those configs are general to Samza (e.g. `app.class`). It would be good to have as few runner-specific steps as possible. `ApplicationRunner` is the interface, so it would be nice to not have to worry about the specific `ApplicationRunner` being used when trying to start the app. I admit that Samza does already do some environment-specific configs (e.g. YARN-specific configs are needed when using `YarnJobFactory`), but we should generally minimize that. I'm not sure if this works, but could we recommend standalone to pass the larger set of submission configs (similar to YARN) also? Then there would be more consistency. It would be easier to describe what submission configs are and how to specify them in general. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
