----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20514/#review40889 -----------------------------------------------------------
samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnContainer.scala <https://reviews.apache.org/r/20514/#comment74139> Would be good to have the time zone here as well. samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnContainer.scala <https://reviews.apache.org/r/20514/#comment74138> Since samza-yarn is transitively pulling in joda-time already (through Scalatra), we might as well make it an explicit compile-time dependency, and use its Duration, Period, and PeriodFormatter class here. This will let us eliminate all of the convertToUpTimeStr code. samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnContainer.scala <https://reviews.apache.org/r/20514/#comment74135> Add an upTime here (like startTime). samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala <https://reviews.apache.org/r/20514/#comment74136> start-time and up-time should be c.startTime and c.upTime, I think, since it's more generally useful than just the string. - Chris Riccomini On April 20, 2014, 10:48 p.m., Zhijie Shen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20514/ > ----------------------------------------------------------- > > (Updated April 20, 2014, 10:48 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-218 Show container up-time in YARN AM > > > Diffs > ----- > > samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 6530bad > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala > fa1642b > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala > 58b2d30 > samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnContainer.scala > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala > 8fce8a7 > > Diff: https://reviews.apache.org/r/20514/diff/ > > > Testing > ------- > > > Thanks, > > Zhijie Shen > >
