> On April 21, 2014, 5:08 p.m., Chris Riccomini wrote: > >
Hi Chris, thanks for reviewing this patch, and pointing out the availability of Joda, which is an amazing lib. I used to leverage it to implement the datetime type of Pig project:-) I simply choose the ISO format for the datetime (have timezone) and the duration, but I'm not sure the formats are friendly enough for people to read. Please let me know how you think about it. Anyway I upload a new patch to demonstrate the changes. - Zhijie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20514/#review40889 ----------------------------------------------------------- On April 20, 2014, 10:48 p.m., Zhijie Shen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20514/ > ----------------------------------------------------------- > > (Updated April 20, 2014, 10:48 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-218 Show container up-time in YARN AM > > > Diffs > ----- > > samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 6530bad > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala > fa1642b > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala > 58b2d30 > samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnContainer.scala > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala > 8fce8a7 > > Diff: https://reviews.apache.org/r/20514/diff/ > > > Testing > ------- > > > Thanks, > > Zhijie Shen > >
