----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20514/#review41359 -----------------------------------------------------------
I'm OK with ISO, but I agree it's a little hard to read. I'll leave it up to you. I think we need to add joda to the build.gradle stuff now, since we're depending on it explicitly as a compile-time dependency. Anyone else have any preferences on time? It seems like we can use a DateFormatter to make any custom time format we want. samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnContainer.scala <https://reviews.apache.org/r/20514/#comment74778> Need to add joda time as an explicit compile-time dependency in build.gradle now, since we're using it. - Chris Riccomini On April 24, 2014, 7:11 a.m., Zhijie Shen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20514/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 7:11 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-218 Show container up-time in YARN AM > > > Diffs > ----- > > samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 6530bad > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala > fa1642b > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala > 58b2d30 > samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnContainer.scala > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala > 8fce8a7 > > Diff: https://reviews.apache.org/r/20514/diff/ > > > Testing > ------- > > > Thanks, > > Zhijie Shen > >
