> On Oct. 28, 2014, 1:44 a.m., Chinmay Soman wrote: > > samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala, > > line 102 > > <https://reviews.apache.org/r/27246/diff/1/?file=734567#file734567line102> > > > > Do you also want to check if topic exists for oldCheckpointTopic ?
Since this tool is applicable only for migration scenario, I assumed that if the new checkpoint topic exists, then old format checkpoint topic probably existed. Do you forsee a scenario where this tool is used when there is no old format checkpoint topic? > On Oct. 28, 2014, 1:44 a.m., Chinmay Soman wrote: > > samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala, > > line 97 > > <https://reviews.apache.org/r/27246/diff/1/?file=734567#file734567line97> > > > > Same here Nice catch. will fix it. > On Oct. 28, 2014, 1:44 a.m., Chinmay Soman wrote: > > samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala, > > line 267 > > <https://reviews.apache.org/r/27246/diff/1/?file=734567#file734567line267> > > > > This method looks pretty big to me. Not strict - but if you could break > > it up into smaller ones - that'll be nice. I tried to. But the interfaces in 0.7 is kind of tightly coupled with the config. Do you see any value in doing so? - Navina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27246/#review58746 ----------------------------------------------------------- On Oct. 27, 2014, 9:40 p.m., Navina Ramesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27246/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 9:40 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Adding checkpoint migration tool LISAMZA-594 > > > Diffs > ----- > > build.gradle 828bce9913db00161971607e4c9ac19c63cecb95 > > samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala > PRE-CREATION > samza-shell/src/main/bash/run-migration-tool.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/27246/diff/ > > > Testing > ------- > > Created a test job "samza-migration-mp" using 0.7 version. Stopped the job > and ran the migration tool. > > > Thanks, > > Navina Ramesh > >
