----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27246/#review58810 -----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala <https://reviews.apache.org/r/27246/#comment99978> I think we should throw an exception. The only way in which this can be none (as far as I can tell) is if the grouper were mis-behaved, and somehow added SSPs to taskNameToSSP that weren't in the lastCheckpoint set, or removed SSPs that were in lastCheckpoint set. In both cases, this is a bad SSP grouper, and an exception should be thrown. - Chris Riccomini On Oct. 28, 2014, 2:06 a.m., Navina Ramesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27246/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 2:06 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Adding checkpoint migration tool LISAMZA-594 > > > Diffs > ----- > > build.gradle 828bce9913db00161971607e4c9ac19c63cecb95 > > samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala > PRE-CREATION > samza-shell/src/main/bash/run-migration-tool.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/27246/diff/ > > > Testing > ------- > > Created a test job "samza-migration-mp" using 0.7 version. Stopped the job > and ran the migration tool. Upgraded to 0.8 version and restarted the job. > Works fine > > > Thanks, > > Navina Ramesh > >
