> On Oct. 28, 2014, 9:24 p.m., Chris Riccomini wrote: > > Ship It!
One nit on the warn(), which will result in a runtime error. Also, please post the updated patch to JIRA when you've updated. The JIRA post is what grants ASF ownership of the code. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27246/#review58874 ----------------------------------------------------------- On Oct. 28, 2014, 9:14 p.m., Navina Ramesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27246/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 9:14 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Adding checkpoint migration tool SAMZA-354 > > > Diffs > ----- > > build.gradle 64c223a > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala > f7db2a1 > > samza-kafka/src/main/scala/org/apache/samza/util/CheckpointMigrationTool.scala > PRE-CREATION > samza-shell/src/main/bash/run-migration-tool.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/27246/diff/ > > > Testing > ------- > > Created a test job "samza-migration-mp" using 0.7 version. Stopped the job > and ran the migration tool. Upgraded to 0.8 version and restarted the job. > Works fine > > > Thanks, > > Navina Ramesh > >
