fgreg commented on a change in pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart URL: https://github.com/apache/incubator-sdap-nexus/pull/88#discussion_r352896947
########## File path: helm/templates/webapp.yaml ########## @@ -0,0 +1,65 @@ +apiVersion: v1 +kind: Service +metadata: + name: nexus-webapp +spec: + type: ClusterIP + ports: + - port: 8083 + name: webapp + selector: + app: nexus-webapp + +--- + +apiVersion: apps/v1 +kind: Deployment +metadata: + labels: + app: nexus-webapp + name: nexus-webapp +spec: + replicas: 1 + selector: + matchLabels: + app: nexus-webapp + template: + metadata: + labels: + app: nexus-webapp + spec: + containers: + - image: {{ .Values.webapp.singleNode.image }} + imagePullPolicy: Always + name: nexus-webapp + env: + - name: CASSANDRA_CONTACT_POINTS Review comment: I don't think any of these environment variables are actually consumed anymore since the `docker-entrypoint.sh` script was removed (with maybe the exception of `MASTER`, `SPARK_LOCAL_IP`, and `PYSPARK_SUBMIT_ARGS`?) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services