fgreg commented on a change in pull request #88: SDAP-215 Use k8s as Spark scheduler and create helm chart URL: https://github.com/apache/incubator-sdap-nexus/pull/88#discussion_r352893936
########## File path: analysis/webservice/algorithms/doms/domsconfig.ini ########## @@ -1,5 +1,5 @@ [cassandra] -host=127.0.0.1 +host=sdap-cassandra Review comment: I understand why you did it but this change along with removing the `docker-entrypoint.sh` file essentially means that the hostname for the solr and cassandra services are now hard-coded into the docker image. To be fair, this is actually a problem with how the application itself loads the ini config files and needs to be fixed outside of this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
