----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45732/#review127049 -----------------------------------------------------------
sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java (line 79) <https://reviews.apache.org/r/45732/#comment190190> As SentryConfigTool class has a few tasks including import and export. It would be better that the command parameter are named indicating its usage. Such as: exportObjectPath instead of objectPath sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java (line 131) <https://reviews.apache.org/r/45732/#comment190191> The same method name suggestion according to the variable name. sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java (line 460) <https://reviews.apache.org/r/45732/#comment190193> We may want to reconsider what character to use for the new concept name. - Jerry Chen On April 5, 2016, 5:49 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45732/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 5:49 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update Sentry config tool for export with specific auth object > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java > 73b0941 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java > c72aea3 > > Diff: https://reviews.apache.org/r/45732/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
