> On April 5, 2016, 8:18 a.m., Jerry Chen wrote: > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java, > > line 460 > > <https://reviews.apache.org/r/45732/diff/2/?file=1325759#file1325759line460> > > > > I suggest to keep single character convention for command line > > parameter instead of "obj" > > > > We can simple choose -b or -t > > > > The description should say, "The path of the object whose privileges > > will be exported"
Thanks for the comments, done. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45732/#review127064 ----------------------------------------------------------- On April 6, 2016, 2:52 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45732/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 2:52 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update Sentry config tool for export with specific auth object > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java > 73b0941 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java > c72aea3 > > Diff: https://reviews.apache.org/r/45732/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
