----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45732/#review127277 -----------------------------------------------------------
sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java (line 538) <https://reviews.apache.org/r/45732/#comment190505> 8 spaces indent problem. Please fix all the instances. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java (line 161) <https://reviews.apache.org/r/45732/#comment190508> How about the tests for cases like: 1. db=db1->table=table1 2. table=table1 (should be exception for case like this?) 3. What the desired behavior for cases such as empty string? I think the bahavior should be the same as null. but test it to make sure. - Jerry Chen On April 6, 2016, 2:52 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45732/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 2:52 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update Sentry config tool for export with specific auth object > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java > 73b0941 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java > c72aea3 > > Diff: https://reviews.apache.org/r/45732/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
