> On July 27, 2016, 10:12 p.m., Anne Yu wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java,
> > line 34
> > <https://reviews.apache.org/r/50404/diff/2/?file=1452127#file1452127line34>
> >
> > Seems this assignment doesn't enable sentry ha. It only validate one
> > system property,
> >
> > if ("true".equalsIgnoreCase(System.getProperty(ENABLE_SENTRY_HA,
> > "false"))) {
> > enableSentryHA = true;
> > }
It does,
sentryServer = SentrySrvFactory.create(
SentrySrvType.INTERNAL_SERVER, sentryConf, enableSentryHA ? 2 : 1);
InternalSentrySrv is passed the number of sentry servers to bring up. Right now
its hard coded to 2.
public InternalSentrySrv(Configuration sentryConf, int numServers)
- Rahul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50404/#review143611
-----------------------------------------------------------
On July 26, 2016, 12:18 a.m., Rahul Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50404/
> -----------------------------------------------------------
>
> (Updated July 26, 2016, 12:18 a.m.)
>
>
> Review request for sentry, Anne Yu and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1415: Provide a hook to stop the active sentry sevice
>
>
> Diffs
> -----
>
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Activator.java
> 730dbb1b6e290c54ad60a5074009fad778d7b77c
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java
> e32e1db5bbb92d35ad4063e9410c583231743edf
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
> 51dde0e5fcfb9dd93a47351efa3a78692bb60202
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java
> PRE-CREATION
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/50404/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rahul Sharma
>
>
