> On July 27, 2016, 9:37 p.m., Rahul Sharma wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java, > > line 47 > > <https://reviews.apache.org/r/50404/diff/2/?file=1452127#file1452127line47> > > > > Are you making that configurable anywhere, like number of servers to be > > used? . If yes, then if you commit that code, I can change this case. > > Anne Yu wrote: > Yeah, I am going to make it configurable passing from maven; default > value will still be 2. In this case, you might want to make it a loop to look > for active server id. > > Rahul Sharma wrote: > I think it should be configurable through the tests also ? someting like > numofServer(defaults to 1) in AbstractTestWithStaticConfiguration
Following up jira: https://issues.apache.org/jira/browse/SENTRY-1432. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/#review143825 ----------------------------------------------------------- On July 26, 2016, 12:18 a.m., Rahul Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50404/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 12:18 a.m.) > > > Review request for sentry, Anne Yu and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > SENTRY-1415: Provide a hook to stop the active sentry sevice > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Activator.java > 730dbb1b6e290c54ad60a5074009fad778d7b77c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java > e32e1db5bbb92d35ad4063e9410c583231743edf > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 51dde0e5fcfb9dd93a47351efa3a78692bb60202 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50404/diff/ > > > Testing > ------- > > > Thanks, > > Rahul Sharma > >
