> On March 14, 2017, 1:49 p.m., Hao Hao wrote: > > Can you add test cases in the intergation test as well, > > TestHDFSIntegrationAdvanced. To ensure cases such as for managed/unmanaged > > table we get expected output. > > Also, it looks like the tests are not all green. Would you mind take a look > > if anything related?
Thanks for the suggestions. I added an integration test in TestHDFSIntegrationAdvanced. - Lei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review168939 ----------------------------------------------------------- On March 22, 2017, 2:27 p.m., Lei Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57570/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 2:27 p.m.) > > > Review request for sentry, Alexander Kolbasov and Hao Hao. > > > Bugs: SENTRY-1644 > https://issues.apache.org/jira/browse/SENTRY-1644 > > > Repository: sentry > > > Description > ------- > > After rename Hive table with partitions, ACLs on the partition paths > disappear. > > It is caused by the fact that renaming on sentry does not move any > sub-namespace. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6 > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java > 0dee1028ac852b12b109e875b2cbbb0bd2efbe03 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java > d079628a0e549e3b179c7a321f82bcf6b580da43 > > > Diff: https://reviews.apache.org/r/57570/diff/2/ > > > Testing > ------- > > mvn test -Dtest=TestHMSPaths > > > Thanks, > > Lei Xu > >
