> On April 6, 2017, 7:05 a.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 360 (patched) > > <https://reviews.apache.org/r/57570/diff/4/?file=1684578#file1684578line382> > > > > comment mentioned to return false if failed, but the code does not > > return a value.
Good catch, Lina. I will address this in the next patch, since this one has already been committed. Thanks. - Lei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review171081 ----------------------------------------------------------- On April 4, 2017, 1:54 p.m., Lei Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57570/ > ----------------------------------------------------------- > > (Updated April 4, 2017, 1:54 p.m.) > > > Review request for sentry, Alexander Kolbasov and Hao Hao. > > > Bugs: SENTRY-1644 > https://issues.apache.org/jira/browse/SENTRY-1644 > > > Repository: sentry > > > Description > ------- > > After rename Hive table with partitions, ACLs on the partition paths > disappear. > > It is caused by the fact that renaming on sentry does not move any > sub-namespace. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6 > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java > 0dee1028ac852b12b109e875b2cbbb0bd2efbe03 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java > d079628a0e549e3b179c7a321f82bcf6b580da43 > > > Diff: https://reviews.apache.org/r/57570/diff/4/ > > > Testing > ------- > > mvn test -Dtest=TestHMSPaths > > > File Attachments > ---------------- > > SENTRY-1644.003-master.patch > > https://reviews.apache.org/media/uploaded/files/2017/03/28/1b82d5bc-0267-42d3-9a9a-9515ed7cb25e__SENTRY-1644.003-master.patch > > > Thanks, > > Lei Xu > >
