> On March 24, 2017, 4:55 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 182 (patched) > > <https://reviews.apache.org/r/57570/diff/2/?file=1672108#file1672108line184> > > > > What does it mean for path elements to point to the direct parent? May > > be you can put some example here? Also, from the code it looks like the > > elements are ordered in a specific way - can you document this as well > > and/or show example?
Okey, I added comments and one example to this function. > On March 24, 2017, 4:55 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 184 (patched) > > <https://reviews.apache.org/r/57570/diff/2/?file=1672108#file1672108line186> > > > > From the code it returns the parent of the *last* element I add more comments to describe the purposed of this function. It basically acts as "mkdir -p /path/to/parent". > On March 24, 2017, 4:55 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Line 195 (original), 214 (patched) > > <https://reviews.apache.org/r/57570/diff/2/?file=1672108#file1672108line216> > > > > Why do you need subList() here? I changed the signature of `createParent()` to take all the path elemenents from the given event, and creates / returns its parent entry. > On March 24, 2017, 4:55 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Line 587 (original), 629 (patched) > > <https://reviews.apache.org/r/57570/diff/2/?file=1672108#file1672108line650> > > > > Why do you need subList() here? Ok, I will change the createParent() to take elements to the desired entry, instead of the parent entry. Hope that it can make the goal of the function clearer. - Lei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review170064 ----------------------------------------------------------- On March 22, 2017, 2:27 p.m., Lei Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57570/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 2:27 p.m.) > > > Review request for sentry, Alexander Kolbasov and Hao Hao. > > > Bugs: SENTRY-1644 > https://issues.apache.org/jira/browse/SENTRY-1644 > > > Repository: sentry > > > Description > ------- > > After rename Hive table with partitions, ACLs on the partition paths > disappear. > > It is caused by the fact that renaming on sentry does not move any > sub-namespace. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > 6d2ab23c3f65af5430ea02563e13c4c4c49aa1c6 > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java > 0dee1028ac852b12b109e875b2cbbb0bd2efbe03 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java > d079628a0e549e3b179c7a321f82bcf6b580da43 > > > Diff: https://reviews.apache.org/r/57570/diff/2/ > > > Testing > ------- > > mvn test -Dtest=TestHMSPaths > > > Thanks, > > Lei Xu > >
