> On April 7, 2017, 9:43 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Line 31 (original), 32 (patched) > > <https://reviews.apache.org/r/58267/diff/1/?file=1686503#file1686503line32> > > > > can be final
It can not be made final. I'm not sure of the exact issue. Datanucleus has issue contructing the objects I guess. > On April 7, 2017, 9:43 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Line 35 (original), 36 (patched) > > <https://reviews.apache.org/r/58267/diff/1/?file=1686503#file1686503line36> > > > > Instead of Set<String> it can use Iterable<STring> What is the advantage of doing so? > On April 7, 2017, 9:43 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Line 61 (original), 64 (patched) > > <https://reviews.apache.org/r/58267/diff/1/?file=1686503#file1686503line64> > > > > No one is calling this This function may be used by Sentry-1587. There are other function in this class that are not used now. I did not touch them as it may be used by Sentry-1587. There are some methods that I think may not be used. I have removed them. > On April 7, 2017, 9:43 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 68 (patched) > > <https://reviews.apache.org/r/58267/diff/1/?file=1686503#file1686503line68> > > > > Naming - this returns a set of paths for the object, so why is it > > called getPathsString? Actual paths are not stored as Strings. We need to expose API's to get the PATH as Set<MPath> and Set<String> > On April 7, 2017, 9:43 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MPath.java > > Lines 24 (patched) > > <https://reviews.apache.org/r/58267/diff/1/?file=1686504#file1686504line24> > > > > can it be final? It can not be made final. I'm not sure of the exact issue. Datanucleus has issue contructing the objects I guess. > On April 7, 2017, 9:43 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.derby.sql > > Lines 14 (patched) > > <https://reviews.apache.org/r/58267/diff/1/?file=1686507#file1686507line23> > > > > Here and in other places - why do we create table first and then > > declare primary key as alter table? Can we declare primary key inline? I was just following the convention followed before. When I had constriant inline, I had comment asking to have it outside for the same reason. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58267/#review171381 ----------------------------------------------------------- On April 10, 2017, 12:44 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58267/ > ----------------------------------------------------------- > > (Updated April 10, 2017, 12:44 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1629 > https://issues.apache.org/jira/browse/SENTRY-1629 > > > Repository: sentry > > > Description > ------- > > Older JDO defination had issues handling multiple paths associtaed with one > Authorizable object. > > Submitted code changes address this issue. Here is the snapshot of the changes > > 1. Change the JDO definition to have Path as separate entity. > 2. SQL changes needed for the handle the new JDO definition. > 3. Application changes to use new JDO definition. > 4. Updated unit test cases to test the case where an authz object is > associated with more than one path. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > 56e456eb37dfbbbb6d0a14402f57dbc400be9b72 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MPath.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > e981bcf0f327346c09cdbe5785fb8824fc62e704 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 802b9c6cbf8e9ad015e37037b809b58c956de746 > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.derby.sql > 1883626262bf4f4936f156a7ac74365b9b5873df > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql > 1829e2fa1f02a4339e7af4bf45a169013e9ec65f > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.oracle.sql > 7de9751892a8ff84067f67d542ac58d33e9148d8 > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.postgres.sql > adf5f1f39596309183f8c80d2c8ad1f1a7730236 > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql > 547bbe8136186658e7fe76ab24934157ea5300ff > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql > 6474389a18ea59da28d3d7125cf227c7aaa7f7aa > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > 1ab83432db233ee4e7aa054adc1b82c26248a099 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql > 0418b298f7cbd8f430733cb329e9fca263bda0f7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql > 68d2c8d53d7c468269ca2c41986ef8651b94f5c7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql > 5376c166659b3e8e373c8c20818f5b1290af90c9 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > aaa0b9fd30bb68fded67f885af4f77bc71398e77 > > > Diff: https://reviews.apache.org/r/58267/diff/2/ > > > Testing > ------- > > Testing done: > 1. Tested the sql changes with derby, mysql, oracle, postgres and db2. > 2. Added unit tests to be sure that the actual issues is addressed. > > > Thanks, > > kalyan kumar kalvagadda > >
