-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58267/
-----------------------------------------------------------
(Updated April 11, 2017, 9:19 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena,
Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Addressed review comments from sasha
Bugs: SENTRY-1629
https://issues.apache.org/jira/browse/SENTRY-1629
Repository: sentry
Description
-------
Older JDO defination had issues handling multiple paths associtaed with one
Authorizable object.
Submitted code changes address this issue. Here is the snapshot of the changes
1. Change the JDO definition to have Path as separate entity.
2. SQL changes needed for the handle the new JDO definition.
3. Application changes to use new JDO definition.
4. Updated unit test cases to test the case where an authz object is associated
with more than one path.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
56e456eb37dfbbbb6d0a14402f57dbc400be9b72
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MPath.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
e981bcf0f327346c09cdbe5785fb8824fc62e704
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
802b9c6cbf8e9ad015e37037b809b58c956de746
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.derby.sql
1883626262bf4f4936f156a7ac74365b9b5873df
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql
1829e2fa1f02a4339e7af4bf45a169013e9ec65f
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.oracle.sql
7de9751892a8ff84067f67d542ac58d33e9148d8
sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.postgres.sql
adf5f1f39596309183f8c80d2c8ad1f1a7730236
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql
547bbe8136186658e7fe76ab24934157ea5300ff
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql
6474389a18ea59da28d3d7125cf227c7aaa7f7aa
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql
1ab83432db233ee4e7aa054adc1b82c26248a099
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql
0418b298f7cbd8f430733cb329e9fca263bda0f7
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql
68d2c8d53d7c468269ca2c41986ef8651b94f5c7
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql
5376c166659b3e8e373c8c20818f5b1290af90c9
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
aaa0b9fd30bb68fded67f885af4f77bc71398e77
Diff: https://reviews.apache.org/r/58267/diff/3/
Changes: https://reviews.apache.org/r/58267/diff/2-3/
Testing
-------
Testing done:
1. Tested the sql changes with derby, mysql, oracle, postgres and db2.
2. Added unit tests to be sure that the actual issues is addressed.
Thanks,
kalyan kumar kalvagadda
