----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172434 -----------------------------------------------------------
LGTM otherwise. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Line 285 (original), 291 (patched) <https://reviews.apache.org/r/58221/#comment245557> nit. Could not start the "periodic executor of" HMSFollower. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Line 312 (original), 320 (patched) <https://reviews.apache.org/r/58221/#comment245558> This is getting trickier. Don't we have to call awaitTermination() after this? - Vamsee Yarlagadda On April 20, 2017, 12:17 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 12:17 a.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > > Diff: https://reviews.apache.org/r/58221/diff/18/ > > > Testing > ------- > > > Thanks, > > Na Li > >
