> On April 25, 2017, 6:53 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 280 (patched) > > <https://reviews.apache.org/r/58221/diff/20/?file=1698641#file1698641line315> > > > > What if (hmsFollowerExecutor == null && hmsFollower != null) ? > > > > In this case you are going to override your existing HMSFollower with a > > new one. This should never happen though because you set it to null in > > close. > > > > So I think you can simplify the check and if you want, you can add a > > precondition that hmsFollower is null.
changed accordingly - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172898 ----------------------------------------------------------- On April 25, 2017, 3:17 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 3:17 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 57b7f88 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > ce73358 > > > Diff: https://reviews.apache.org/r/58221/diff/21/ > > > Testing > ------- > > > Thanks, > > Na Li > >
