> On April 18, 2017, 6:10 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 74 (patched) > > <https://reviews.apache.org/r/58481/diff/3/?file=1693586#file1693586line74> > > > > SENTRY-1587 is addressing this issue. There is no need to make this > > change again. > > Na Li wrote: > The approach used in SENTRY-1587 may not be desirable. It introduces > extra remote procedure call, and therefore more overhead and delay. It was > work around for a bug in HIVE-15761. Once it is fixed, we don't need to add > that extra remote procedure call. > > So it is better to fix the duplicated log message in this Jira case.
I talked with Kalyan. We both agree that right now, we can accept both my change for this case and Hao's change to work around HIVE-15761. Once HIVE-15761 is fixed, we can remove Hao's change that calls "client.getCurrentNotificationEventId()" - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172233 ----------------------------------------------------------- On April 19, 2017, 2:43 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58481/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 2:43 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1674 > https://issues.apache.org/jira/browse/SENTRY-1674 > > > Repository: sentry > > > Description > ------- > > Do not log message when CurrentEventID does not change and there is no > updates for HMSFollower > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > > Diff: https://reviews.apache.org/r/58481/diff/4/ > > > Testing > ------- > > > Thanks, > > Na Li > >
