> On April 19, 2017, 6:18 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 259 (original), 257 (patched) > > <https://reviews.apache.org/r/58481/diff/3-4/?file=1693586#file1693586line259> > > > > This still preserves the original problem when events are not processed > > for some reason - you will get a flood of logs. In this case events would > > be always non-empty. > > Na Li wrote: > In this case, something is defintely wrong. I think we should log such > situation. Otherwise, how do we detect that there are new changes, but we > could not process them? > > Na Li wrote: > I thought the original issue is that when there is no new update, we > still log the same message again and again. If there are updates, processing > them will advance currentEventID; not processing them should be error > condition
the behavior is updated. track last logged ID. log debug message if it changes with update. log error message once if it does not change with update. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172380 ----------------------------------------------------------- On April 20, 2017, 6:14 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58481/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 6:14 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1674 > https://issues.apache.org/jira/browse/SENTRY-1674 > > > Repository: sentry > > > Description > ------- > > Do not log message when CurrentEventID does not change and there is no > updates for HMSFollower > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > > Diff: https://reviews.apache.org/r/58481/diff/6/ > > > Testing > ------- > > > Thanks, > > Na Li > >
