> On April 20, 2017, 3:52 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 258 (patched) > > <https://reviews.apache.org/r/58481/diff/4/?file=1693984#file1693984line258> > > > > You may want to revisit the comment. This check all about avoid > > logging. This check is to avoid furthur processing when there are not > > events.
There was type in my above comment. You may want to revisit the comment. This check not all about avoid logging. This check is to avoid furthur processing and also logging when there are no events - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172502 ----------------------------------------------------------- On April 20, 2017, 4:28 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58481/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 4:28 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1674 > https://issues.apache.org/jira/browse/SENTRY-1674 > > > Repository: sentry > > > Description > ------- > > Do not log message when CurrentEventID does not change and there is no > updates for HMSFollower > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > > Diff: https://reviews.apache.org/r/58481/diff/5/ > > > Testing > ------- > > > Thanks, > > Na Li > >
