----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172554 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Lines 270 (patched) <https://reviews.apache.org/r/58481/#comment245657> I see issue with the logic. Let's take a simple case. 1. When the HMS follower comes up for the first time, there are some notifications, lastLoggedEventId is updated. In the second attempt there are notifications, then currentEventID will be equal to lastLoggedEventId. In this case, Error is logged. - kalyan kumar kalvagadda On April 20, 2017, 6:14 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58481/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 6:14 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1674 > https://issues.apache.org/jira/browse/SENTRY-1674 > > > Repository: sentry > > > Description > ------- > > Do not log message when CurrentEventID does not change and there is no > updates for HMSFollower > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > > Diff: https://reviews.apache.org/r/58481/diff/6/ > > > Testing > ------- > > > Thanks, > > Na Li > >
