----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review173861 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Lines 75 (patched) <https://reviews.apache.org/r/58221/#comment246910> This shouldn't be here. It is the code from another JIRA. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 95 (original) <https://reviews.apache.org/r/58221/#comment246911> Please add a comment explaining why these two constructors are different. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Lines 132 (patched) <https://reviews.apache.org/r/58221/#comment246912> This shouldn't be here - it is a code from another JIRA sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 313 (patched) <https://reviews.apache.org/r/58221/#comment246927> We may end up with hmsfollower without the executor here. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 314 (patched) <https://reviews.apache.org/r/58221/#comment246925> finally should be on previous line sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 318 (patched) <https://reviews.apache.org/r/58221/#comment246924> It can't be null here sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 322 (patched) <https://reviews.apache.org/r/58221/#comment246928> This should be moved to the finally clause of the previous try block sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 326 (patched) <https://reviews.apache.org/r/58221/#comment246926> catch should be on previous line sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 331 (patched) <https://reviews.apache.org/r/58221/#comment246932> Since we are using conf, for consistency let's add conf to the arguments sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 332 (patched) <https://reviews.apache.org/r/58221/#comment246929> This can be asserted with precondition sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 363 (patched) <https://reviews.apache.org/r/58221/#comment246930> we should set sentrystorecleanservice to null here sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 368 (patched) <https://reviews.apache.org/r/58221/#comment246931> we an assert this with precondition sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java Lines 24 (patched) <https://reviews.apache.org/r/58221/#comment246916> Please avoid wildcard imports for such utility classes, import what you need. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java Lines 157 (patched) <https://reviews.apache.org/r/58221/#comment246919> Nit, this is a full sentence, so should start with a capital letter and end with a dot. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java Lines 165 (patched) <https://reviews.apache.org/r/58221/#comment246917> This can be package-private Also, please use shorter line. Official limit is 120. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java Lines 166 (patched) <https://reviews.apache.org/r/58221/#comment246918> Why would we call it with pool = null? This probably should be Preconditions.assertNonNull. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java Lines 177 (patched) <https://reviews.apache.org/r/58221/#comment246921> This can be replaced with be {} instead of %s and format. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java Lines 180 (patched) <https://reviews.apache.org/r/58221/#comment246922> rename ie to ignored sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java Line 172 (original), 172 (patched) <https://reviews.apache.org/r/58221/#comment246913> Why do we need this delay in the first place? Can it be 0? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java Line 421 (original), 424 (patched) <https://reviews.apache.org/r/58221/#comment246914> Can you explain this change? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java Line 441 (original), 444 (patched) <https://reviews.apache.org/r/58221/#comment246915> Please use string constant for col1_role instead of copying it in multiple places. - Alexander Kolbasov On May 3, 2017, 7:20 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated May 3, 2017, 7:20 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > ec8676e > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > ce73358 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 834ed41 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java > 1ace07c > > > Diff: https://reviews.apache.org/r/58221/diff/23/ > > > Testing > ------- > > > Thanks, > > Na Li > >
