> On May 4, 2017, 3:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 75 (patched) > > <https://reviews.apache.org/r/58221/diff/23/?file=1707216#file1707216line75> > > > > This shouldn't be here. It is the code from another JIRA. > > Na Li wrote: > I can remove it
I need it here to avoid unit test failure when using local meta store. Since my code change changes the timing, it is more likely to use local meta store if we don't prevent it here. > On May 4, 2017, 3:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 95 (original) > > <https://reviews.apache.org/r/58221/diff/23/?file=1707216#file1707216line96> > > > > Please add a comment explaining why these two constructors are > > different. Kalyan mentioned that he has created a Jira to address the difference of the constructors, so can I leave it as it is for this jira? > On May 4, 2017, 3:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > > Line 172 (original), 172 (patched) > > <https://reviews.apache.org/r/58221/diff/23/?file=1707219#file1707219line172> > > > > Why do we need this delay in the first place? Can it be 0? I think the reason it was very large is because if the Hive meta store is not up yet, HMSFollower could connect to the local meta store, and the test will fail. So large initial delay is a work around of this issue. Since we avoid connect to the local meta store, we don't need such large delay any more. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review173861 ----------------------------------------------------------- On May 5, 2017, 3:47 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 3:47 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 99549bc > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > ce73358 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 834ed41 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > 2ebe561 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > 212c465 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > b5247d0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java > 1ace07c > > > Diff: https://reviews.apache.org/r/58221/diff/25/ > > > Testing > ------- > > > Thanks, > > Na Li > >
