----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/ -----------------------------------------------------------
(Updated Nov. 16, 2017, 7:30 p.m.) Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vadim Spector. Summary (updated) ----------------- SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received Repository: sentry Description ------- Currently we only seem to log when all conditions that lead to getting a snapshot are validated, and eventually a full snapshot is received. However, if for some reason a particular condition was invalid we don't log as to why. This leaves no room for knowing definitely what might have been the reason as to why a snapshot was not received from HMS. Diffs ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7217dea7a sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java c4cc91806 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java 6ec163b1d Diff: https://reviews.apache.org/r/63881/diff/1/ Testing ------- mvn -f sentry-provider/sentry-provider-db/pom.xml test Thanks, Arjun Mishra
