> On Nov. 16, 2017, 8:45 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 2912 (original), 2913 (patched) > > <https://reviews.apache.org/r/63881/diff/1/?file=1894376#file1894376line2913> > > > > 'an paths' is not correct. 'an' is used on singular nouns. It should be > > 'a'
Exactly. What you see on the left is Old. I changed it to what is on the right, without the 'an' > On Nov. 16, 2017, 8:45 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 249-250 (patched) > > <https://reviews.apache.org/r/63881/diff/1/?file=1894377#file1894377line249> > > > > Do we need to log the notification ID here? The log for 'has no hms > > notifications' is enough, isn't it? I am logging the notification Id "latestSentryNotificationId". I can change it to hms notifications is empty in sentry store. Would that work? > On Nov. 16, 2017, 8:45 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 408 (original), 414 (patched) > > <https://reviews.apache.org/r/63881/diff/1/?file=1894377#file1894377line416> > > > > This can be too verbose. If there are new notifications every 5s for > > instance, and we don't care about thos, then this will be printed every 5s. > > Can we do something better here that avoids such amount of verbose logs? How often is isNotificationProcessed false? I think thats a rare case that's why I changed it to INFO - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review191242 ----------------------------------------------------------- On Nov. 16, 2017, 7:30 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63881/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 7:30 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and > Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Currently we only seem to log when all conditions that lead to getting a > snapshot are validated, and eventually a full snapshot is received. However, > if for some reason a particular condition was invalid we don't log as to why. > This leaves no room for knowing definitely what might have been the reason as > to why a snapshot was not received from HMS. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 7217dea7a > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > c4cc91806 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java > 6ec163b1d > > > Diff: https://reviews.apache.org/r/63881/diff/1/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test > > > Thanks, > > Arjun Mishra > >
