> On Nov. 16, 2017, 7:41 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 348 (original), 353 (patched) > > <https://reviews.apache.org/r/63881/diff/1/?file=1894377#file1894377line355> > > > > You can add a log indicating we don't persist the full snapshot.
I thought of that. But it is already handled. If you were to look at setLastProcessedNotificationID method, the first statement is a log statement like below. LOGGER.debug("Persisting Last Processed Notification ID {}", notificationId); And since this method is being called only in one place I thought it would be redundant. - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63881/#review191233 ----------------------------------------------------------- On Nov. 16, 2017, 7:30 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63881/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 7:30 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and > Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Currently we only seem to log when all conditions that lead to getting a > snapshot are validated, and eventually a full snapshot is received. However, > if for some reason a particular condition was invalid we don't log as to why. > This leaves no room for knowing definitely what might have been the reason as > to why a snapshot was not received from HMS. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 7217dea7a > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > c4cc91806 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java > 6ec163b1d > > > Diff: https://reviews.apache.org/r/63881/diff/1/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test > > > Thanks, > > Arjun Mishra > >