> On Nov. 21, 2017, 7:30 a.m., Vadim Spector wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > > Line 265 (original), 265 (patched) > > <https://reviews.apache.org/r/63975/diff/1/?file=1898135#file1898135line265> > > > > Lina, Assert.assertTrue() produces very unhelpful message, telling > > nothing about what we expect vs what we get; it only says that the two > > values are different. > > I suggest using Assert.assertEquals() instead, both for tableName and > > dbName. Specifically: > > > > instead of > > Assert.assertNotNull(msg, y); > > Assert.assertTrue(x.equalsIgnoreCase(y.getName())); > > > > do this: > > Assert.assertNotNull(msg, y); > > Assert.assertNotNull(msg_1, y.getName()); > > Assert.assertEquals(x.toLowerCase(), y.getName().toLowerCase()); > > > > where the last line will throw an exception telling exactly the > > expected value and the actual value, if they are different. This is far > > more helpful.
agree. I will make the change accordingly - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191564 ----------------------------------------------------------- On Nov. 21, 2017, 3:32 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63975/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 3:32 a.m.) > > > Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > if db name is not set in "case HiveParser.TOK_ALTERTABLE" at > HiveAuthzBindingHook.preAnalyze, make sure it is set > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > e4620ea > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > aa99595 > > > Diff: https://reviews.apache.org/r/63975/diff/1/ > > > Testing > ------- > > unit test > > > Thanks, > > Na Li > >
