> On Nov. 21, 2017, 7:51 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > > Lines 283 (patched) > > <https://reviews.apache.org/r/63975/diff/1/?file=1898134#file1898134line283> > > > > Why do we need an extra boolean Can we just check for currDB == null ? > > Or it isn't null in this case? > > Na Li wrote: > It is not null. The currDB is initialized to be "*" > > Arjun Mishra wrote: > Is it wrong to break after currDB/currOutDB is set? Do we still have to > stay in the for loop?
Also we can avoid using isDBSet by initially setting it to getCanonicalDb() before entering the for loop - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63975/#review191566 ----------------------------------------------------------- On Nov. 21, 2017, 5:08 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63975/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 5:08 p.m.) > > > Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > if db name is not set in "case HiveParser.TOK_ALTERTABLE" at > HiveAuthzBindingHook.preAnalyze, make sure it is set > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > e4620ea > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > aa99595 > > > Diff: https://reviews.apache.org/r/63975/diff/2/ > > > Testing > ------- > > unit test > > > Thanks, > > Na Li > >
