----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/#review193725 -----------------------------------------------------------
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/HiveAuthzBindingHookBaseV2.java Lines 811 (patched) <https://reviews.apache.org/r/64452/#comment272343> Can we add a log statement here? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java Lines 831 (patched) <https://reviews.apache.org/r/64452/#comment272344> Can we add a log statement here? sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java Lines 107 (patched) <https://reviews.apache.org/r/64452/#comment272345> Can we add a log statement here? - Arjun Mishra On Dec. 13, 2017, 6:51 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64452/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2017, 6:51 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, Sergio > Pena, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Update the code to make sure user without group but with role has proper > access. > test case is added for the scenario that user has no group but with desired > role. > test case is added for the scenario that user has no group and no privilege > to allow the access > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/HiveAuthzBindingHookBaseV2.java > 5a21dd3 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java > 9c60c22 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > 005724f > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > c730a03 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestGrantUserToRole.java > 5364937 > > > Diff: https://reviews.apache.org/r/64452/diff/1/ > > > Testing > ------- > > unit tests > > > Thanks, > > Na Li > >
