> On March 28, 2018, 9:33 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java > > Line 243 (original), 249 (patched) > > <https://reviews.apache.org/r/66336/diff/1/?file=1989686#file1989686line249> > > > > What's wrong with the original message?
you are right, I should not be taking about HMS threads here. I get it. I will update the logs. valueevent is wokeup when the value is than or equal to e.getValue(). Current doesn't say that. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66336/#review200140 ----------------------------------------------------------- On March 28, 2018, 4:14 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66336/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 4:14 p.m.) > > > Review request for sentry and Na Li. > > > Bugs: SENTRY-2190 > https://issues.apache.org/jira/browse/SENTRY-2190 > > > Repository: sentry > > > Description > ------- > > Debug logging in CounterWait is not good enough to actually an issue around > this area. It's a good idea to extend the current logging. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java > d8c82970b56b1599a07f0e26edab8ed3d59b9948 > > > Diff: https://reviews.apache.org/r/66336/diff/1/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
