----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66336/#review200218 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java Lines 191 (patched) <https://reviews.apache.org/r/66336/#comment280876> This will print as: "not blocked, returning from wait 125" This is somewhat confusing. The important thing there is that the request for 125 is can proceed immediately. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java Lines 203 (patched) <https://reviews.apache.org/r/66336/#comment280877> See comment above. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java Line 213 (original), 216 (patched) <https://reviews.apache.org/r/66336/#comment280878> Again, "returning from wait 125" is confusing message. - Alexander Kolbasov On March 29, 2018, 5:25 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66336/ > ----------------------------------------------------------- > > (Updated March 29, 2018, 5:25 p.m.) > > > Review request for sentry and Na Li. > > > Bugs: SENTRY-2190 > https://issues.apache.org/jira/browse/SENTRY-2190 > > > Repository: sentry > > > Description > ------- > > Debug logging in CounterWait is not good enough to actually an issue around > this area. It's a good idea to extend the current logging. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java > d8c82970b56b1599a07f0e26edab8ed3d59b9948 > > > Diff: https://reviews.apache.org/r/66336/diff/2/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
