> On March 29, 2018, 8:41 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java > > Lines 191 (patched) > > <https://reviews.apache.org/r/66336/diff/2/?file=1990346#file1990346line191> > > > > can you put the currentId in the log message? That would be helpful
currentId is a atomic variable. Using this variable just for logging might not be desirable. This response is applicable to rest of your comments. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66336/#review200210 ----------------------------------------------------------- On March 30, 2018, 11:10 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66336/ > ----------------------------------------------------------- > > (Updated March 30, 2018, 11:10 p.m.) > > > Review request for sentry and Na Li. > > > Bugs: SENTRY-2190 > https://issues.apache.org/jira/browse/SENTRY-2190 > > > Repository: sentry > > > Description > ------- > > Debug logging in CounterWait is not good enough to actually an issue around > this area. It's a good idea to extend the current logging. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java > d8c82970b56b1599a07f0e26edab8ed3d59b9948 > > > Diff: https://reviews.apache.org/r/66336/diff/3/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
