----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68624/#review208323 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 818 (original), 818 (patched) <https://reviews.apache.org/r/68624/#comment292162> Do you know what AccessConstants.SOME is about? It seems to be the same as AccessConstants.ALL sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 866 (patched) <https://reviews.apache.org/r/68624/#comment292165> if action is ALL or ACTION_ALL, SHOULD you continue? Before calling this function, if the action to grant is all, and all is already granted, we can do nothing - Na Li On Sept. 4, 2018, 7:02 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68624/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2018, 7:02 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. > > > Bugs: sentry-2315 > https://issues.apache.org/jira/browse/sentry-2315 > > > Repository: sentry > > > Description > ------- > > Fixes the issue where GRANT ALL does not include the ALTER privilege. > > It does not fix the REVOKE command where revoking a single privilege will end > up revoking ALL and granting all invididual supported privileges. For now, > such behavior only works for SELECT and INSERT. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > db8c08ba0839400c65658e90ebd18906fed9919f > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 6b732ea5a89dafd94a6a3ae9c423747118352d84 > > > Diff: https://reviews.apache.org/r/68624/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
