----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68624/#review208362 -----------------------------------------------------------
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java Lines 927 (patched) <https://reviews.apache.org/r/68624/#comment292247> Can you add the test cases that 1) user already has "ALL with grant option", and then grant with "ALL", what happens? 2) user already has "ALL", and then grant with "ALL with grant option", what happens? - Na Li On Sept. 4, 2018, 7:02 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68624/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2018, 7:02 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li. > > > Bugs: sentry-2315 > https://issues.apache.org/jira/browse/sentry-2315 > > > Repository: sentry > > > Description > ------- > > Fixes the issue where GRANT ALL does not include the ALTER privilege. > > It does not fix the REVOKE command where revoking a single privilege will end > up revoking ALL and granting all invididual supported privileges. For now, > such behavior only works for SELECT and INSERT. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > db8c08ba0839400c65658e90ebd18906fed9919f > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 6b732ea5a89dafd94a6a3ae9c423747118352d84 > > > Diff: https://reviews.apache.org/r/68624/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
