-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68624/
-----------------------------------------------------------

(Updated Sept. 5, 2018, 4:57 p.m.)


Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.


Changes
-------

Added test cases to verify that grant all replaces grant all with grant and 
viceversa.


Bugs: sentry-2315
    https://issues.apache.org/jira/browse/sentry-2315


Repository: sentry


Description
-------

Fixes the issue where GRANT ALL does not include the ALTER privilege. 

It does not fix the REVOKE command where revoking a single privilege will end 
up revoking ALL and granting all invididual supported privileges. For now, such 
behavior only works for SELECT and INSERT.


Diffs (updated)
-----

  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
 db8c08ba0839400c65658e90ebd18906fed9919f 
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
 6b732ea5a89dafd94a6a3ae9c423747118352d84 


Diff: https://reviews.apache.org/r/68624/diff/2/

Changes: https://reviews.apache.org/r/68624/diff/1-2/


Testing
-------


Thanks,

Sergio Pena

Reply via email to