> On Oct. 8, 2018, 4:18 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 140-145 (patched) > > <https://reviews.apache.org/r/68547/diff/11/?file=2094968#file2094968line140> > > > > Invalidate or cleanUp? I like to separate the verbs. Invalidate means > > the current cache is not valid and it will be replaced (but not necessary > > removed from memory). Clean is what is says, clean from memory. > > > > Also, I think we should see the future of HDFS Federation. We can get a > > benefit if we avoid cleaning the cache when multiple NN request images from > > Sentry. This way Sentry will return the cache image.
I am fine with that. Some of the team members were against using too much heap - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68547/#review209315 ----------------------------------------------------------- On Oct. 5, 2018, 7:11 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68547/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2018, 7:11 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2370 > https://issues.apache.org/jira/browse/SENTRY-2370 > > > Repository: sentry > > > Description > ------- > > When NN requests path updates from sentry and if it exceeds the time > threshold, on consecutive attempts sentry will attempt to fetch the full > update from scratch. Instead it should cache it and update the cache before > sending it to NN > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 08b16a4df > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > f86ce6f83 > > > Diff: https://reviews.apache.org/r/68547/diff/11/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
