generally fine..


http://codereview.appspot.com/1807042/diff/18001/19001
File
java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java
(right):

http://codereview.appspot.com/1807042/diff/18001/19001#newcode629
java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java:629:
this.operationPath.equals(that.operationPath));
suggest Objects.equal(this.operationPath, that.operationPath) to handle
nulls

http://codereview.appspot.com/1807042/diff/18001/19006
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java
(right):

http://codereview.appspot.com/1807042/diff/18001/19006#newcode45
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:45:
public static final String ACCEL_GADGET_PARAM_NAME = new
String("accelGadget");
ugh...

http://codereview.appspot.com/1807042/diff/18001/19003
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java
(right):

http://codereview.appspot.com/1807042/diff/18001/19003#newcode65
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java:65:
if (HtmlAccelServlet.ACCEL_GADGET_PARAM_NAME == name) {
remind me why we can't use .equals() here?

http://codereview.appspot.com/1807042/show

Reply via email to