http://codereview.appspot.com/1807042/diff/18001/19001 File java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java (right):
http://codereview.appspot.com/1807042/diff/18001/19001#newcode629 java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java:629: this.operationPath.equals(that.operationPath)); On 2010/07/20 21:56:16, Paul Lindner wrote:
suggest Objects.equal(this.operationPath, that.operationPath) to
handle nulls Done. http://codereview.appspot.com/1807042/diff/18001/19003 File java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java (right): http://codereview.appspot.com/1807042/diff/18001/19003#newcode65 java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java:65: if (HtmlAccelServlet.ACCEL_GADGET_PARAM_NAME == name) { On 2010/07/20 21:56:16, Paul Lindner wrote:
remind me why we can't use .equals() here?
From johnfargo 2010/07/12 20:36:34 this isn't a misuse -- the ==-check ensures that a requestor cannot fake the accel_gadget_param_name by passing the param on the query string. ...hence the "Ugh" inducing change to HtmlAccelServlet.java http://codereview.appspot.com/1807042/show
