On 2010/07/20 23:18:53, jasvir wrote:
http://codereview.appspot.com/1807042/diff/18001/19003#newcode65
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java:65:
if (HtmlAccelServlet.ACCEL_GADGET_PARAM_NAME == name) {
On 2010/07/20 21:56:16, Paul Lindner wrote:
> remind me why we can't use .equals() here?
From johnfargo 2010/07/12 20:36:34
this isn't a misuse -- the ==-check ensures that a requestor cannot
fake the
accel_gadget_param_name by passing the param on the query string.
...hence the "Ugh" inducing change to HtmlAccelServlet.java
Aha, okay. Maybe a comment in both places mentioning this.
http://codereview.appspot.com/1807042/show
