> On 2011-07-22 02:20:04, Paul Lindner wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js, > > line 23 > > <https://reviews.apache.org/r/1179/diff/1/?file=26756#file26756line23> > > > > curious why you removed the var...
I was being consistent with global exports and obj/function definitions. With simple optimizations, I don't think that it makes a difference. I'd have to check. I had originally been toying with advanced optimizations. > On 2011-07-22 02:20:04, Paul Lindner wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js, > > line 301 > > <https://reviews.apache.org/r/1179/diff/1/?file=26757#file26757line301> > > > > good catch.. > > One of the great things about closure. The js tests fail and you can find closure complaining in the log. :) > On 2011-07-22 02:20:04, Paul Lindner wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java, > > line 102 > > <https://reviews.apache.org/r/1179/diff/1/?file=26761#file26761line102> > > > > Yes, please instantiate a JUL logger Will do, patch update incoming. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1179/#review1164 ----------------------------------------------------------- On 2011-07-22 02:05:03, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1179/ > ----------------------------------------------------------- > > (Updated 2011-07-22 02:05:03) > > > Review request for shindig. > > > Summary > ------- > > Enable closure with simple optimizations turned on. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsCompileMode.java > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/CompilationProcessor.java > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java > 1149429 > > Diff: https://reviews.apache.org/r/1179/diff > > > Testing > ------- > > Existing js tests pass > > > Thanks, > > Dan > >
