----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1179/#review1178 -----------------------------------------------------------
almost there! http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js <https://reviews.apache.org/r/1179/#comment2471> nit: trailing space. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java <https://reviews.apache.org/r/1179/#comment2474> Add imports for JsCompiler / ClosureJsCompiler. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java <https://reviews.apache.org/r/1179/#comment2472> nit: trailing space here and below. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java <https://reviews.apache.org/r/1179/#comment2482> Can you inject a constant from shindig.properties instead? This would also allow someone to turn off Closure Compiler entirely if set to NONE... http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java <https://reviews.apache.org/r/1179/#comment2473> nit: trailing space - Paul On 2011-07-22 13:30:59, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1179/ > ----------------------------------------------------------- > > (Updated 2011-07-22 13:30:59) > > > Review request for shindig. > > > Summary > ------- > > Enable closure with simple optimizations turned on. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsCompileMode.java > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/CompilationProcessor.java > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java > 1149429 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java > 1149429 > > Diff: https://reviews.apache.org/r/1179/diff > > > Testing > ------- > > Existing js tests pass > > > Thanks, > > Dan > >
